Bring KAL up to date and enable new linters #2554
Conversation
|
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XXL
| policy: SuggestFix | ||
| uniqueMarkers: | ||
| namingconventions: | ||
| conventions: |
There was a problem hiding this comment.
I wonder if it would make sense to add one for https://github.com/openshift/enhancements/blob/master/dev-guide/api-conventions.md#use-resource-name-rather-than-kind-in-object-references ?
I think this could have a violation matcher that catches Kind naming and suggest a fix that it should be Resource instead?
| usePatchStrategy: Ignore | ||
| useProtobuf: Ignore | ||
| forbiddenmarkers: | ||
| markers: |
There was a problem hiding this comment.
kubebuilder:validation:Pattern as we prefer using CEL expressions?
There was a problem hiding this comment.
kubebuilder:validation:UniqueItems as well? IIRC this marker doesn't actually work right?
There was a problem hiding this comment.
Yeah those are both good suggestions
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/verified by CI checks |
openshift-ci-robot
added
the
verified
|
@JoelSpeed: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This updates KAL and enables a few new linters
metav1.Duration+nullabletag